Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the separator between apps in Appstore visible #142

Open
danielhollas opened this issue Feb 22, 2023 · 2 comments
Open

Make the separator between apps in Appstore visible #142

danielhollas opened this issue Feb 22, 2023 · 2 comments

Comments

@danielhollas
Copy link
Contributor

danielhollas commented Feb 22, 2023

In the appstore we render all apps below each other. There is <hr> element as a visual separator, but it is not that much visible, (on one of my monitors with lower brightness, it is actually invisible).

display(ipw.HTML("<hr>")) # horizontal line
, but (at least in my browser) it is not visible since its color is white.

We need to add some styling to it. We should also adjust the overall whitespace around the apps, it seems currently there's a bit too much of it.

@danielhollas
Copy link
Contributor Author

Styling an <hr> tag seems to be bit of a pain, see

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hr
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_hr_align_css
https://stackoverflow.com/questions/4151743/how-can-i-change-the-thickness-of-my-hr-tag
https://www.thoughtco.com/styling-horizontal-rule-tag-3466399

It would be nicer instead of inserting a separate <hr> in between tags to utilize the ::before CSS pseudoclass. Alternatively, we could use a top border around the app.

@danielhollas
Copy link
Contributor Author

As part of this, we could also take a look at removing supposedly superfluouos HBoxes, see #130 (comment)

@danielhollas danielhollas removed their assignment Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant