deps: Vendor more_itertools.consecutive_groups #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 83.62% 83.64% +0.01%
==========================================
Files 16 16
Lines 3517 3521 +4
==========================================
+ Hits 2941 2945 +4
Misses 576 576
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
force-pushed
the
remove-moreitertools
branch
from
6dc123a to
a5613d5
Compare
danielhollas
force-pushed
the
remove-moreitertools
branch
from
a5613d5 to
2b84761
Compare
danielhollas
force-pushed
the
remove-moreitertools
branch
from
2b84761 to
fdae078
Compare
|
I'll merge this to include in an alpha release. But please still feel free to review and pushback against this, happy to incorporate feedback in a followup. |
|
thanks! It appeared before I join the team, so feel free to optimize it, I have no opinion on these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more_itertoolspackage contains useful functions built on top of stdlib itertools, but we only use a single function from the package so let's vendor it and remove the dependency.This means app developers can happily use this package without worrying about version clashes with AWB.
Part of #392