Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and test setup #11

Open
mfherbst opened this issue Nov 7, 2024 · 2 comments
Open

Tests and test setup #11

mfherbst opened this issue Nov 7, 2024 · 2 comments

Comments

@mfherbst
Copy link
Collaborator

mfherbst commented Nov 7, 2024

@Technici4n Now you do the juliasetup in the tests from the setup config file. I wonder if this is a good idea. Are the side effects under control ? Is it perhaps better to do this in the .github/workflows/ci.yml ?

@Technici4n
Copy link
Collaborator

I did it in this way to make sure that running pytest locally is enough. I didn't consider side effects, should I be worried about them?

@mfherbst
Copy link
Collaborator Author

Well the very least you should be more specific in the AiidaDFTK version. Not every 0.1 will work, only the most recent (so 0.1.9). See https://pkgdocs.julialang.org/v1/compatibility/ for info (a very important website to bookmark ... I always forget the details)

Also I'm a bit surprised about the Pkg.resolve(); Pkg.precompile(). Should a single Pkg.instantiate() not be enough ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants