-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More user friendly yes/no prompt in verdi computer delete
#6422
Comments
This was discussed in the PR that changed it. As you can see, the original proposed string was |
So the idea here was that deleting a computer doesn't only delete the isolated computer. To keep provenance, it also deletes all the connected nodes, so all processes of a user that were run on this computer. So it's an operation that should only be done with great care. Personally, I'd also be fine with |
I'm ok with the original suggestion and generally keeping a consistent style across verdi commands, as long as the default stays N |
We thought perhaps using a different response than the usual "y" would make sense to prevent accidental data loss. |
I conclude that changing it to EDIT: I am sorry for the back and forth but reading now the conversation more carefully and looking at the deletion in other parts of the code. All people were also okay with the |
Hi can I work on this issue? @agoscinski |
Sure! |
This is a very good idea. ➕ Same thing could be done when deleting a code node or a profile. |
Describe the problem
Looking at the yes/no prompt of
verdi computer delete
Would suggest to do [y/N] or [yes/NO]. I tend for the former as it is used in Debian-based system, also I saw this used in other verdi shell prompts.
Also I would accept
y
,yes
,n
,no
in both cases as valid input. Here again, my intuition comes from using a Debian-based system.My environment
Python 3.11.0, Ubuntu 22.04
The text was updated successfully, but these errors were encountered: