CI: remove matrix redundancy between test-install and ci
#6780
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6780 +/- ##
=======================================
Coverage 78.15% 78.15%
=======================================
Files 564 564
Lines 42643 42643
=======================================
Hits 33322 33322
Misses 9321 9321 ☔ View full report in Codecov by Sentry. |
| @@ -162,7 +162,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: ['3.9', '3.10', '3.11', '3.12'] | |||
| python-version: ['3.10', '3.11'] # '3.9' and '3.12' are tested via ci-code.yml | |||
There was a problem hiding this comment.
Note that they are not exactly redundant, since in test-ci the dependencies are installed from the lockfile, while here they come from pip resolution (i.e. they will resolve to the latest version of the dependencies).
There was a problem hiding this comment.
Hi @danielhollas, thanks for the review, and checking here :)
I understand your point. However, I still find it somewhat redundant since it primarily checks the resolved dependencies rather than testing aiida's functionalities. In the worst case, dependency resolution could be tested separately.
If the dependencies are resolved correctly, we should technically be fine. So, running the entire test suite twice for this reason might be unnecessary.
We can discuss this further in the next aiida's meeting (tomorrow).
There was a problem hiding this comment.
Yes, I am not against this change, just wanted to point it out.
Fix for #6779
As of now, two set of tests, are redundant for no apparant reasons.
For example, see for the first commit that I made in this PR:
https://github.com/aiidateam/aiida-core/actions/runs/13631859178/job/38101273251?pr=6780#step:7:1
and
https://github.com/aiidateam/aiida-core/actions/runs/13631859180/job/38101194890?pr=6780#step:7:1
The second one has only an extra flag
--cov aiida, which is irrelevant in terms of redundancy.I don't see a reason why these tests has to be run two times.
This PR, removes that to save time on CI.