You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, when FcPath was part of aiida-firecrest@chrisjsewell could control explicitly if cache should be enable or disable based on specific purpose, in this way: self._cwd.joinpath(remotesource).enable_cache()
But when the class eth-cscs/pyfirecrest#43 got merged into pyfirecrest, they took enable_cache() away, in such a way that when you make a joinpath() the new path is just copying the flag from the original path. So here if self._cwd has cache=True then joinpath() returns an FCPath with cache=True, likewise for cache=False.
For now we have self._cwd with cache=True always. The thing that I'm not entirely sure if that is going to mess things up when files on remote is changed...
In my manual tests, I haven't seen any wrong return when files on remote has changed and yet cache=True.
But still this has to be investigated thoroughly.
The text was updated successfully, but these errors were encountered:
Previously, when
FcPath
was part ofaiida-firecrest
@chrisjsewell could control explicitly if cache should be enable or disable based on specific purpose, in this way:self._cwd.joinpath(remotesource).enable_cache()
But when the class eth-cscs/pyfirecrest#43 got merged into
pyfirecrest
, they tookenable_cache()
away, in such a way that when you make ajoinpath()
the new path is just copying the flag from the original path. So here ifself._cwd
hascache=True
thenjoinpath()
returns anFCPath
withcache=True
, likewise forcache=False
.For now we have
self._cwd
withcache=True
always. The thing that I'm not entirely sure if that is going to mess things up when files on remote is changed...In my manual tests, I haven't seen any wrong return when files on remote has changed and yet cache=True.
But still this has to be investigated thoroughly.
The text was updated successfully, but these errors were encountered: