Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Cleanup before stable release #353

Open
4 tasks
GeigerJ2 opened this issue Nov 20, 2024 · 0 comments
Open
4 tasks

Dev: Cleanup before stable release #353

GeigerJ2 opened this issue Nov 20, 2024 · 0 comments

Comments

@GeigerJ2
Copy link
Contributor

I think before the stable release, we should definitely take some time to clean up the code base. Some tasks that come to mind:

  • Reduce the usage of kwargs. While very convenient, it's hard to understand what's going on. I think we should consider which arguments functions require, and be more explicit.
  • CI: Move to the aiida-core tech stack, e.g. Ruff
  • Fix (or add) type annotations. We could use basedpyright for that, great tool. Though, to be consistent with aiida-core it should actually be mypy, though basedpyright seems to be more strict.
  • Proper testing directory structure, as currently all tests are just in top-level test_<something>.py files

Happy to discuss this during the coding week. At the current stage, I'm a bit overwhelmed and not sure where to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant