New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we expose decorators at the package top-level? #354

Open

GeigerJ2 opened this issue Nov 20, 2024 · 0 comments

Contributor

GeigerJ2 commented Nov 20, 2024 •

edited

Loading

Currently, we expose both task, as well as Task at the top-level API, with the first being the decorator and the second one the class:

aiida-workgraph/aiida_workgraph/__init__.py

Lines 10 to 14 in 2559c21

    
           from .decorator import task, build_task 
        
           __version__ = "0.4.5" 
        
           __all__ = ["WorkGraph", "Task", "task", "build_task"]

I found this a bit confusing, personally.

EDIT: As noted by @superstar54, Task should not be exposed.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment