Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude URL/Host patterns #382

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Exclude URL/Host patterns #382

wants to merge 5 commits into from

Conversation

ascheman
Copy link
Member

This PR resolves #276.
It was perfectly prepared by @elebeida for the core module and the Gradle plugin, I was only streamlining a little bit.
Additionally I extended it to the CLI and the Maven plugin.

I will squash some of the latest changes (and leave them here only for visibility and ease of review).
For sake of simplicity I have already squashed the original changes.

Besides @elebeida I therefore kindly ask

  • @rdmueller for a review as he was the original requestor
  • @truhroth as he is most familiar with the Maven plugin

@ascheman ascheman self-assigned this Feb 24, 2025
@ascheman ascheman mentioned this pull request Feb 24, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

Test Results

113 files  + 14  113 suites  +14   2m 18s ⏱️ +11s
472 tests + 18  470 ✅ +17  0 💤 ±0   2 ❌ + 1 
594 runs  +130  537 ✅ +88  0 💤 ±0  57 ❌ +42 

For more details on these failures, see this check.

Results for commit 4f4ab88. ± Comparison against base commit b85b141.

This pull request removes 60 and adds 41 tests. Note that renamed tests count towards both. 
                                <a href="http://aim.org">improve</a>' 
                                <a href="http://arc42.de">arc42.de</a> and some more text
                                <a href="https://arc42.org">arc42 over https</a> even more
                                <a href="local-file.jpg">local file</a> again, text
                                <img src="" alt="2">
                                <img src="t.doc" alt="r"> '
    <area shape="circle" coords="0,1,1" href="#test2">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
    <area shape="rect" coords="0,0,1,1" href="#test1" >
    <area shape="rect" coords="0,0,1,1" href="#test1">
…

org.aim42.htmlsanitycheck.ConfigurationSpec ‑ can set and retrieve hostsToExclude
org.aim42.htmlsanitycheck.ConfigurationSpec ‑ can set and retrieve urls and hosts to exclude
org.aim42.htmlsanitycheck.ConfigurationSpec ‑ can set and retrieve urlsToExclude
org.aim42.htmlsanitycheck.check.BrokenHttpLinksCheckerSpec ‑ excludes are not checked
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="foo" >bad header</h2>, msg: ImageMap "map1" refers to missing link "id1"., #4]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="id1">aim42 header</h2>, msg: 2 imagemaps with identical name "map1" exist., #1]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
</map>
, msg: ImageMap "map1" has no area tags., #3]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="id1">aim42 header</h2>, msg: ImageMap "map1" not referenced by any image., #2]
org.aim42.htmlsanitycheck.gradle.HtmlSanityCheckTaskFunctionalSpec ‑ can exclude specific URLs and Gradle version 7.6.3
org.aim42.htmlsanitycheck.gradle.HtmlSanityCheckTaskFunctionalSpec ‑ can exclude specific URLs and Gradle version 8.0.2
…

♻️ This comment has been updated with latest results.

@ascheman ascheman force-pushed the feature/276-exclude-urls-squashed branch from 7e65e27 to 4f4ab88 Compare February 24, 2025 22:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rdmueller
rdmueller approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@rdmueller rdmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. haven't tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmueller rdmueller rdmueller approved these changes

@truhroth truhroth Awaiting requested review from truhroth

Assignees

@ascheman ascheman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude certain URLs from checking
3 participants
@ascheman @rdmueller @elebeida