Please auidit the code and make possible changes on codebase

[uwussimo]

No description provided.

[Prathapkarumanchi]

Can you seeing this error message?

[xelopsys]

why you are trying to fetch blogsList an object?

[xelopsys]

it's not necessary as long as you have [component] page so it catches all other routes, but if we consider developing it further it would be best to overwrite login page with all components from [component] and all other routes would 404* page

[xelopsys]

i recommend you to not define environment properties within constants, cause environment variables will be declared on build time, so it would be best just to declare it with process.env , not depending on any other constants

[shivamvora]

How would access if I need in any file? Should I use directly process.env.something?

…

On Tue, 18 Apr, 2023, 12:34 pm Jamshid Jurakulov, ***@***.***> wrote: [image: Screenshot 2023-04-18 at 11 54 07] <https://user-images.githubusercontent.com/46597388/232697513-d6771ab1-8b66-4ff6-8f21-639315674ec9.png> i recommend you to not define environment properties within constants, cause environment variables will be declared on build time, so it would be best just to declare it with process.env , not depending on any other constants — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOERCWMT3GV2OMX2YKTTY23XBY4IJANCNFSM6AAAAAAXBD3DLY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[xelopsys]

yes it would be better

[shivamvora]

Ok

…

On Tue, 18 Apr, 2023, 12:37 pm Jamshid Jurakulov, ***@***.***> wrote: yes it would be better — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOERCWNWJUQPRRC3K6KXRLTXBY4TVANCNFSM6AAAAAAXBD3DLY> . You are receiving this because you commented.Message ID: ***@***.***>

[xelopsys]

and please stick to one type of declaring functional components in react, and it would be better if you use "function"

[xelopsys]

and the rest looking good! Good job!

[shivamvora]

Ok, will do that.

…

On Tue, 18 Apr, 2023, 12:39 pm Jamshid Jurakulov, ***@***.***> wrote: [image: Screenshot 2023-04-18 at 11 52 16] <https://user-images.githubusercontent.com/46597388/232698808-db15dbc2-5971-47af-9a9b-50f9ffecfc1c.png> [image: Screenshot 2023-04-18 at 11 52 22] <https://user-images.githubusercontent.com/46597388/232698828-b24b68fb-7ca3-4bcd-bfdd-9e9880f0643c.png> and please stick to one type of declaring functional components in react, and it would be better if you use "function" — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOERCWLAYBSFYQZ5MG2XX53XBY433ANCNFSM6AAAAAAXBD3DLY> . You are receiving this because you commented.Message ID: ***@***.***>

[xelopsys]

it's not necessary as long as you have [component] page so it catches all other routes, but if we consider developing it further it would be best to overwrite login page with all components from [component] and all other routes would 404* page

and one thing, dont use different languages at declaring pages, use typescript or javascript not both (it would be clean code).

[Prathapkarumanchi]

React component should start with Capital letter instead of blogDetail it should be BlogDetails
same with JoinList