Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon elasticsearch signed requests support #48

Open
hellysmile opened this issue Sep 12, 2017 · 5 comments
Open

Amazon elasticsearch signed requests support #48

hellysmile opened this issue Sep 12, 2017 · 5 comments
Assignees

Comments

@hellysmile
Copy link
Member

hellysmile commented Sep 12, 2017

elasticsearch-py requests based realization
http://elasticsearch-py.readthedocs.io/en/master/index.html?#running-on-aws-with-iam

Amazon docs:
https://aws.amazon.com/blogs/security/how-to-control-access-to-your-amazon-elasticsearch-service-domain/

@hellysmile hellysmile self-assigned this Sep 12, 2017
@asvetlov
Copy link
Member

Pleaase add a link to docs. What the hell is it?

@hellysmile
Copy link
Member Author

Links attached, sorry

@jeremyblow
Copy link

This would be nice to have, but I think it would take some work. Requests allows a callable http_auth object to float all the way through from the transport class to a PreparedRequest object which can then (and probably not safely sooner) process the final body and headers for signing. There are also a few more gymnastics needed, for instance ensuring header date (if provided) matches the signing key's scope date.

At the surface, aiohttp looks similar, but underneath the implementation is different. Headers could, in theory, float through to the ClientSession from the ES init (c/o transport/connection), but after a quick scan I didn't see an opportunity to trigger a callable/hook. Perhaps I'm overlooking an approach within aiohttp.

@hellysmile
Copy link
Member Author

Some hints to reuse parts from aiobotocore elastic/elasticsearch-py#706

@sloev
Copy link

sloev commented Mar 5, 2018

any news on this, we need it as well.
@hellysmile did you try something with the flow from aiobotocore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants