Blanket "except Exception" obfuscating server-specific parsing problems

[spolloni]

Hello and thanks for maintaining this useful package!

I am experiencing an issue very similar to this one, where due to a server intricacy, aioftp is failing to list and parse the host's root directory.

It took me a long while to figure this out, because the following line:

aioftp/aioftp/client.py

Line 786 in 2fe66a1

except Exception:

prevents the much more useful exception below from being raised:

aioftp/aioftp/client.py

Line 535 in 2fe66a1

raise ValueError("All parsers failed to parse", b, ex)

As an example, the following code:

import asyncio
import aioftp

async def main():
    async with aioftp.Client.context('ftp.kymartian.ky.gov') as client:
        print(await client.list())

asyncio.run(main())

will NOT fail and simply print [], which seems like an undesirable behavior. If the more informative ValueError exception was raised instead, it would have been much clearer that using the parse_list_line_custom argument was necessary.

Is there a specific reason for using very generic try/except here?

[pohmelie]

AFAIR, try/except was introduced for windows ftp servers support. Since they can return dir command output. What is your suggestion in this case?

[spolloni]

Since they can return dir command output.

Sorry I don't follow. How would this be affected by removing the try/except ?

[pohmelie]

Sorry for a delay. I got your point and agreed, it's better not to shadow errors. Changed in 2e0c317

Will release right after resolve one more issue.