Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual vs path-based addressing in docs #10

Open
malthe opened this issue Apr 4, 2022 · 1 comment
Open

Virtual vs path-based addressing in docs #10

malthe opened this issue Apr 4, 2022 · 1 comment

Comments

@malthe
Copy link
Contributor

malthe commented Apr 4, 2022

The README docs are using path-based addressing which is a deprecated mode. AWS is moving to virtual host-based addressing, eventually retiring the former mode.

Perhaps the docs should be changed to reflect this so that the examples will be based on a client which has been set up all the way with a specific bucket in the virtual host.

@mosquito
Copy link
Collaborator

mosquito commented Apr 4, 2022

So the Amazon S3 is a one of supported implementations, in practice we are having the deals with S3 compatible services, and the path-based addressing is using in general. You are right about it, the examples should contain information about that. This module doesn't see the difference between path and domain based addressing, the user have to set the different base URL. I think that should be written in the README. Feel free to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants