Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecrecover implementation issue #81

Open
vaishnavipanchal23 opened this issue Oct 29, 2019 · 1 comment
Open

ecrecover implementation issue #81

vaishnavipanchal23 opened this issue Oct 29, 2019 · 1 comment

Comments

@vaishnavipanchal23
Copy link

Web3 version: aion-web3 v1.2.6-beta.0

Implementation issue of recover function https://github.com/aionnetwork/aion_web3/blob/v1.1/packages/web3-eth-accounts/src/index.js#L316

Current implementation:
Returns the address by retrieving the public key from first 32 bytes of the signature. This ignores the signature verification completely.

Expected implementation:
Return the address of the signer only if the signature is verified for the given message.

Note: Also, this function name should be edverify.

@rakeshgohel01
Copy link

Two things

  1. Confirm the claim that there is a missing implementation for ecrecover.

  2. For web3 implementation, ecrecover has been used in the context of secp256k1 curve and must be separated from edverify for ed25519 signature verification which is primarily used by Aion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants