Skip to content

Commit

Permalink
Get rid of mentions to python 3.8 in docs and classifiers
Browse files Browse the repository at this point in the history
  • Loading branch information
nhuet authored and g-poveda committed Oct 4, 2024
1 parent ffb83be commit 31d9bad
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 14 deletions.
8 changes: 4 additions & 4 deletions docs/contribute.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ Here are the steps to follow:
cd scikit-decide
```

- Set proper python version (e.g. 3.8.11) for the scikit-decide project.
- Set proper python version (e.g. 3.12.2) for the scikit-decide project.
```shell
pyenv local 3.8.11
pyenv local 3.12.2
```

- Update pip installer (the one that `pyenv` makes you use).
Expand All @@ -92,7 +92,7 @@ Here are the steps to follow:

- Specify to poetry the python version to use so that it creates the appropriate virtual environment.
```shell
poetry env use 3.8.11
poetry env use 3.12.2
```

- Install all dependencies as defined in `poetry.lock`, build and install the c++ library.
Expand All @@ -114,7 +114,7 @@ as it can also be installed by conda via the conda-forge channel.

- Create and activate a conda environment with the proper python version for the scikit-decide project.
```shell
conda create -n test_dev_skdecide python=3.8.11
conda create -n test_dev_skdecide python=3.12.2
conda activate test_dev_skdecide
```
- Update pip installer
Expand Down
16 changes: 8 additions & 8 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,35 +73,35 @@ export DO_SKIP_MZN_CHECK=1
Please note however that the library is never tested without minizinc (or minizinc versions < 2.6).


### Python 3.8+ environment
### Python 3.9+ environment

The use of a virtual environment for scikit-decide is recommended, and you will need to ensure that the environment use a Python version greater than 3.8.
The use of a virtual environment for scikit-decide is recommended, and you will need to ensure that the environment use a Python version greater than 3.9.
This can be achieved either by using [conda](https://docs.conda.io/en/latest/) or by using [pyenv](https://github.com/pyenv/pyenv) (or [pyenv-win](https://github.com/pyenv-win/pyenv-win) on windows)
and [venv](https://docs.python.org/fr/3/library/venv.html) module.

The following examples show how to create a virtual environment with Python version 3.8.13 with the mentioned methods.
The following examples show how to create a virtual environment with Python version 3.9.18 with the mentioned methods.

#### With conda (all platforms)

```shell
conda create -n skdecide python=3.8.13
conda create -n skdecide python=3.9.18
conda activate skdecide
```

#### With pyenv + venv (Linux/MacOS)

```shell
pyenv install 3.8.13
pyenv shell 3.8.13
pyenv install 3.9.18
pyenv shell 3.9.18
python -m venv skdecide-venv
source skdecide-venv/bin/activate
```

#### With pyenv-win + venv (Windows)

```shell
pyenv install 3.8.13
pyenv shell 3.8.13
pyenv install 3.9.18
pyenv shell 3.9.18
python -m venv skdecide-venv
skdecide-venv\Scripts\activate
```
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ classifiers = [
"Programming Language :: C++",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Topic :: Software Development",
"Topic :: Scientific/Engineering",
]
Expand Down

0 comments on commit 31d9bad

Please sign in to comment.