Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary or undocumented D.T_predicate #108

Open
neo-alex opened this issue Nov 19, 2021 · 0 comments
Open

Unnecessary or undocumented D.T_predicate #108

neo-alex opened this issue Nov 19, 2021 · 0 comments

Comments

@neo-alex
Copy link
Collaborator

🐛 Bug

D.T_predicate was added to the list of user-defined types to support a very specific case (related to multi-agent domains, to enable direct alignment with another existing API). Currently it is poorly documented, so it is not clear that it only relates to the return type of the is_terminal method.

Expected behavior

The main suggestion here would be to (try and) remove D.T_predicate which seems a bit overkill for its purpose (or at least preconfigure it so that it is automatically set to the expected value in single & multi agent cases). There could be interesting alternatives to serve the same purpose without it, e.g. adding a is_agent_terminal(agent_id) method to multi-agent domains and keeping a boolean is_terminal method to know if the whole environment is done.

In case the suggestion above is rejected, D.T_predicate should at least be better documented for the end-user to know how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant