Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GymDiscreteActionDomain does not discretize Box space correctly #175

Closed
galleon opened this issue Jan 12, 2022 · 2 comments
Closed

GymDiscreteActionDomain does not discretize Box space correctly #175

galleon opened this issue Jan 12, 2022 · 2 comments
Assignees

Comments

@galleon
Copy link
Contributor

galleon commented Jan 12, 2022

🐛 Bug

GymDiscreteActionDomain does not discretize Box space correctly

To Reproduce

Steps to reproduce the behaviour:

  1. I have a gym env which define a Box(low=-1, high=1, shape=(2,)) action space
  2. When using IW which uses a custom wrapper inheriting from GymDiscreteActionDomain
  3. The action space is not properly discretized as the domain._applicable_actions.get_elements() contains [-1., 1.875]which is not a valid action

Expected behavior

I expected all generated elements to be in [-1, 1]^2

@nhuet
Copy link
Contributor

nhuet commented Oct 6, 2023

Should be closed as duplicated with #205 which has been solved.

@fteicht
Copy link
Collaborator

fteicht commented Oct 9, 2023

Solved in PR #205

@fteicht fteicht closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants