Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug when termination is None in new TerminationOutcome #424

Merged

Conversation

fteicht
Copy link
Collaborator

@fteicht fteicht commented Sep 27, 2024

Creating a TerminationOutcome object with a termination equal to None raised an exception because self.observation is not defined by the TerminationOutcome class

Creating a TerminationOutcome object with a termination equal to None raised an exception because self.observation is not defined by the TerminationOutcome class
@fteicht fteicht added the bug Something isn't working label Sep 27, 2024
@fteicht fteicht requested a review from neo-alex September 27, 2024 16:51
Copy link
Collaborator

@g-poveda g-poveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g-poveda g-poveda merged commit ffb83be into airbus:master Oct 1, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants