Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies scipy and d-o #427

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Update dependencies scipy and d-o #427

merged 2 commits into from
Oct 10, 2024

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Oct 3, 2024 •
edited
Loading

  • scipy: was always installed even though optional because not put in the proper extras
  • d-o:
    • make it mandatory as we use it for hyperparameters management in core
    • update to 0.4.0
    • update doc as minizinc install in now optional for d-o (only needed if running minizinc-based solvers)
    • update workflow as DO_SKIP_MZN_CHECK is not needed anymore
    • make binder env use minizinc 2.8.5 (>=2.8 as needed by d-o)
    • make colab install minizinc 2.8.5, and only for scheduling notebook
    • remove colab installation stepos related to cffi which was due to python-mip which pinned it to an old version (and is not needed by d-o anymore)

@nhuet nhuet marked this pull request as draft October 3, 2024 08:12
@nhuet
Copy link
Contributor Author

nhuet commented Oct 3, 2024

This PR will work once next release for d-o is done.

@nhuet nhuet force-pushed the clean-deps branch 3 times, most recently from d725b11 to 21f1e58 Compare October 3, 2024 08:53
nhuet added 2 commits October 7, 2024 12:45
@nhuet
Update when scipy should be installed
8d05435
@nhuet
Update d-o dependency
8f95f01 
- make it mandatory as we use it for hyperparameters management in core
- update to 0.4.0
- update doc as minizinc install in now optional for d-o (only needed if
  running minizinc-based solvers)
- update workflow as DO_SKIP_MZN_CHECK is not needed anymore
- make binder env use minizinc 2.8.5 (>=2.8 as needed by d-o)
- make colab install minizinc 2.8.5, and only for scheduling notebook
- remove colab installation stepos related to cffi which was due to
  python-mip which pinned it to an old version (and is not needed by d-o
  anymore)
@nhuet nhuet force-pushed the clean-deps branch 2 times, most recently from 208a1ea to 8f95f01 Compare October 7, 2024 17:00
@nhuet nhuet marked this pull request as ready for review October 7, 2024 17:00
g-poveda
g-poveda approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@g-poveda g-poveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to me

@g-poveda g-poveda merged commit 821ecec into airbus:master Oct 10, 2024
33 checks passed
@nhuet nhuet deleted the clean-deps branch October 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-poveda g-poveda g-poveda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhuet @g-poveda