Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebooks #431

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix notebooks #431

merged 2 commits into from
Oct 18, 2024

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Oct 10, 2024 •
edited
Loading

  • fix maze_utils.py
  • fix flight_planning notebook for openap 2.0

@nhuet nhuet marked this pull request as ready for review October 11, 2024 08:08
g-poveda
g-poveda approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@g-poveda g-poveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nhuet nhuet marked this pull request as draft October 11, 2024 08:12
@nhuet nhuet marked this pull request as ready for review October 15, 2024 12:05
@nhuet
Fix notebook flight-planning
ef87386 
Starting from openap 2.0, the fuel model needs further parameters.
They are not available for A380 in openap so we keep only the cell using
Poll-Schumann performance model.
@fteicht fteicht self-requested a review October 18, 2024 09:32
@g-poveda g-poveda merged commit a13d22d into airbus:master Oct 18, 2024
33 checks passed
@nhuet nhuet deleted the fix-notebooks branch November 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-poveda g-poveda g-poveda approved these changes

@fteicht fteicht fteicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhuet @fteicht @g-poveda