From 28cfe8a661cd89c7a30f2e668364823b9d028bc4 Mon Sep 17 00:00:00 2001 From: Edward Gao Date: Tue, 17 Dec 2024 15:01:23 -0800 Subject: [PATCH] update disablings --- .../iceberg/v2/IcebergV2WriteTest.kt | 39 ++++--------------- 1 file changed, 8 insertions(+), 31 deletions(-) diff --git a/airbyte-integrations/connectors/destination-iceberg-v2/src/test-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt b/airbyte-integrations/connectors/destination-iceberg-v2/src/test-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt index 4ff4dc9b6ab0..db2d733a57a2 100644 --- a/airbyte-integrations/connectors/destination-iceberg-v2/src/test-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt +++ b/airbyte-integrations/connectors/destination-iceberg-v2/src/test-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt @@ -40,17 +40,7 @@ abstract class IcebergV2WriteTest( nullEqualsUnset = true, ) { @Test - @Disabled( - "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime" - ) - override fun testBasicTypes() { - super.testBasicTypes() - } - - @Test - @Disabled( - "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime" - ) + @Disabled("This is currently hanging forever and we should look into why") override fun testInterruptedTruncateWithPriorData() { super.testInterruptedTruncateWithPriorData() } @@ -62,29 +52,21 @@ abstract class IcebergV2WriteTest( } @Test - // @Disabled - override fun testContainerTypes() { - super.testContainerTypes() - } - - @Test - @Disabled( - "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime" - ) + @Disabled("This is currently hanging forever and we should look into why") override fun resumeAfterCancelledTruncate() { super.resumeAfterCancelledTruncate() } @Test - @Disabled("This is expected") - override fun testAppendSchemaEvolution() { - super.testAppendSchemaEvolution() + // @Disabled + override fun testContainerTypes() { + super.testContainerTypes() } @Test - // @Disabled - override fun testUnions() { - super.testUnions() + @Disabled("This is expected (dest-iceberg-v2 doesn't yet support schema evolution)") + override fun testAppendSchemaEvolution() { + super.testAppendSchemaEvolution() } } @@ -101,11 +83,6 @@ class IcebergGlueWriteTest : override fun testContainerTypes() { super.testContainerTypes() } - - @Test - override fun testUnions() { - super.testUnions() - } } @Disabled(