From dad53b72a5ef3f8126b181c9f08a8e7226d7a98d Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 16 Jan 2024 12:36:13 +0100 Subject: [PATCH] Source Google Ads: Convert to airbyte-lib (#34007) --- .../connectors/source-google-ads/main.py | 11 ++--------- .../connectors/source-google-ads/metadata.yaml | 2 +- .../connectors/source-google-ads/setup.py | 5 +++++ .../source-google-ads/source_google_ads/run.py | 16 ++++++++++++++++ docs/integrations/sources/google-ads.md | 1 + 5 files changed, 25 insertions(+), 10 deletions(-) create mode 100644 airbyte-integrations/connectors/source-google-ads/source_google_ads/run.py diff --git a/airbyte-integrations/connectors/source-google-ads/main.py b/airbyte-integrations/connectors/source-google-ads/main.py index d18603af20f37..2824c49559439 100644 --- a/airbyte-integrations/connectors/source-google-ads/main.py +++ b/airbyte-integrations/connectors/source-google-ads/main.py @@ -2,14 +2,7 @@ # Copyright (c) 2023 Airbyte, Inc., all rights reserved. # - -import sys - -from airbyte_cdk.entrypoint import launch -from source_google_ads import SourceGoogleAds -from source_google_ads.config_migrations import MigrateCustomQuery +from source_google_ads.run import run if __name__ == "__main__": - source = SourceGoogleAds() - MigrateCustomQuery.migrate(sys.argv[1:], source) - launch(source, sys.argv[1:]) + run() diff --git a/airbyte-integrations/connectors/source-google-ads/metadata.yaml b/airbyte-integrations/connectors/source-google-ads/metadata.yaml index 82d21ed64f367..4c09baf87a5c6 100644 --- a/airbyte-integrations/connectors/source-google-ads/metadata.yaml +++ b/airbyte-integrations/connectors/source-google-ads/metadata.yaml @@ -11,7 +11,7 @@ data: connectorSubtype: api connectorType: source definitionId: 253487c0-2246-43ba-a21f-5116b20a2c50 - dockerImageTag: 3.3.0 + dockerImageTag: 3.3.1 dockerRepository: airbyte/source-google-ads documentationUrl: https://docs.airbyte.com/integrations/sources/google-ads githubIssueLabel: source-google-ads diff --git a/airbyte-integrations/connectors/source-google-ads/setup.py b/airbyte-integrations/connectors/source-google-ads/setup.py index d0694f67fa7ba..7211a092ff545 100644 --- a/airbyte-integrations/connectors/source-google-ads/setup.py +++ b/airbyte-integrations/connectors/source-google-ads/setup.py @@ -14,6 +14,11 @@ TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock", "freezegun", "requests-mock"] setup( + entry_points={ + "console_scripts": [ + "source-google-ads=source_google_ads.run:run", + ], + }, name="source_google_ads", description="Source implementation for Google Ads.", author="Airbyte", diff --git a/airbyte-integrations/connectors/source-google-ads/source_google_ads/run.py b/airbyte-integrations/connectors/source-google-ads/source_google_ads/run.py new file mode 100644 index 0000000000000..dd759a035015c --- /dev/null +++ b/airbyte-integrations/connectors/source-google-ads/source_google_ads/run.py @@ -0,0 +1,16 @@ +# +# Copyright (c) 2023 Airbyte, Inc., all rights reserved. +# + + +import sys + +from airbyte_cdk.entrypoint import launch +from source_google_ads import SourceGoogleAds +from source_google_ads.config_migrations import MigrateCustomQuery + + +def run(): + source = SourceGoogleAds() + MigrateCustomQuery.migrate(sys.argv[1:], source) + launch(source, sys.argv[1:]) diff --git a/docs/integrations/sources/google-ads.md b/docs/integrations/sources/google-ads.md index c509c5dd54dcc..da21953520739 100644 --- a/docs/integrations/sources/google-ads.md +++ b/docs/integrations/sources/google-ads.md @@ -280,6 +280,7 @@ Due to a limitation in the Google Ads API which does not allow getting performan | Version | Date | Pull Request | Subject | |:---------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------------------------------------------------------------| +| `3.3.1` | 2024-01-16 | [34007](https://github.com/airbytehq/airbyte/pull/34007) | prepare for airbyte-lib | | `3.3.0` | 2024-01-12 | [34212](https://github.com/airbytehq/airbyte/pull/34212) | Remove metric from query in Ad Group stream for non-manager account | | `3.2.1` | 2024-01-12 | [34200](https://github.com/airbytehq/airbyte/pull/34200) | Disable raising error for not enabled accounts | | `3.2.0` | 2024-01-09 | [33707](https://github.com/airbytehq/airbyte/pull/33707) | Add possibility to sync all connected accounts |