Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Amazon Seller Partner: add stream name to report options list #38657

Merged
merged 5 commits into from
May 27, 2024

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/airbyte-internal-issues/issues/6302

How

  • Add report_name option to the report_options_list config var
  • process it during the instantiation of the streams
  • add report_name property to report classes so we could match report options with the report class
  • Migrate configs
  • Add unit tests

User Impact

ability to create multiple streams based on one report with different report options

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 6:42pm

@tolik0
Copy link
Contributor

tolik0 commented May 27, 2024

Please fix the formatting, spec acceptance test and unit tests.

@davydov-d davydov-d enabled auto-merge (squash) May 27, 2024 18:44
@davydov-d davydov-d merged commit 4665198 into master May 27, 2024
30 checks passed
@davydov-d davydov-d deleted the ddavydov/source-asp-extend-report-options-list branch May 27, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants