feat: implement logic to determine super types between iceberg types #50412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
subodh1810
changed the title
frifriSF59
reviewed
Dec 24, 2024
Comment on lines
69
to
77
| private fun validateTypeIds(typeId1: TypeID, typeId2: TypeID) { | ||
| val unsupportedTypeIds = setOf(BINARY, DECIMAL, FIXED, UUID, MAP, TIMESTAMP_NANO) | ||
| if (typeId1 in unsupportedTypeIds || typeId2 in unsupportedTypeIds) { | ||
| val badTypeId = if (typeId1 in unsupportedTypeIds) typeId1 else typeId2 | ||
| throw IllegalArgumentException( | ||
| "Unsupported or unmapped Iceberg type: $badTypeId. Please implement handling if needed." | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
I find this slightly easier to read:
Suggested change
| private fun validateTypeIds(typeId1: TypeID, typeId2: TypeID) { | |
| val unsupportedTypeIds = setOf(BINARY, DECIMAL, FIXED, UUID, MAP, TIMESTAMP_NANO) | |
| if (typeId1 in unsupportedTypeIds || typeId2 in unsupportedTypeIds) { | |
| val badTypeId = if (typeId1 in unsupportedTypeIds) typeId1 else typeId2 | |
| throw IllegalArgumentException( | |
| "Unsupported or unmapped Iceberg type: $badTypeId. Please implement handling if needed." | |
| ) | |
| } | |
| } | |
| private fun validateTypeIds(typeId1: TypeID, typeId2: TypeID) { | |
| val unsupportedTypes = setOf(BINARY, DECIMAL, FIXED, UUID, MAP, TIMESTAMP_NANO) | |
| val providedTypes = listOf(typeId1, typeId2) | |
| val foundUnsupported = providedTypes.filter { it in unsupportedTypes } | |
| if (foundUnsupported.isNotEmpty()) { | |
| throw IllegalArgumentException( | |
| "Unsupported or unmapped Iceberg type(s): ${foundUnsupported.joinToString()}. Please implement handling if needed." | |
| ) | |
| } | |
| } |
frifriSF59
reviewed
Dec 24, 2024
| validateTypeIds(existingTypeId, incomingTypeId) | ||
|
|
||
| // If promotion is not allowed by Iceberg, fail fast. | ||
| if (!TypeUtil.isPromotionAllowed(existingType, incomingType)) { |
There was a problem hiding this comment.
Should this be happening even before validateTypeIds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/airbytehq/airbyte-internal-issues/issues/10918