-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source-opsgenie] add support for additional incident fields #50880
base: master
Are you sure you want to change the base?
Conversation
The current documentation for OpsGenie's /v1/incidents API does not show the full set of fields that are actually available: https://docs.opsgenie.com/docs/incident-api#list-incidents Adds support for the following: description, ownerTeam, extraProperties, links, impactStartDate, actions
@nkupton is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
Hey Nick thanks for the contribution. Are you going to continue it? Need some help? |
Hi Marcos, thanks. I was able to successfully test this in my instance, and made a guess about how to proceed with versioning. Let me know how it looks to you? |
@@ -1,4 +1,4 @@ | |||
version: 4.3.0 | |||
version: 0.4.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you reverting to an old version of the manifest? Please return to 4.3.0 or higher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30157b4 - align manifest version with release notes version
It felt inconsistent to me to increment this to 4.6.0 when the release notes will be on 0.4.6. Seemed like a typo in the manifest.
Would you be willing to make the call here? What should this value be?
Adds support for the following fields:
ownerTeam, extraProperties, links, impactStartDate, actions
What
It appears that the initial version of this connector was created with the OpsGenie API documentation as a primary guide. However, real world responses show several important additional fields that are supported by the /v1/incidents List API, despite not being documented in the sample response: https://docs.opsgenie.com/docs/incident-api#list-incidents
Example:
How
Expand the schema to include fields not adequately documented in the OpsGenie API.
Review guide
extraProperties
is actually what was intended by thedetails
field, but I left both to avoid removing any.details
is the term used by OpsGenie for Incident Create, butextraProperties
is the term used to retrieve it by the Incident Get/List APIs.https://docs.opsgenie.com/docs/incident-api#create-incident
https://docs.opsgenie.com/docs/incident-api#get-incident
https://docs.opsgenie.com/docs/incident-api#list-incident
User Impact
Important additional fields can be synced into Airbyte destinations.
Can this PR be safely reverted and rolled back?