[Session token authentication] Parameterized "Session token retrieval" URL is adding a trailing slash (/)

[isaac-perez-nexthink]

Topic

Session token authentication

Relevant information

Hi!

I've found what seems a bug when trying to create a builder using Session token authentication.

When using a parameterized URL, Airbyte is adding a trailing slash to the request, that makes some third party to fail on this

In I use a hardcoded URL instead, it works as expected:

[marcosmarxm]

cc @airbytehq/dev-extensibility

[bazarnov]

@chandlerprall @lmossman to confirm this is not a UI bug, please?

If so, we'd assume the interpolation adds unnecessary symbols and thus would go deeper into the CDK side of things for investigation.

[lmossman]

@bazarnov I believe this is actually being caused by the UI.

We wanted to have just a single URL input for the session token retrieval URL, but because the HttpRequester in the CDK has a required url_base and a required path, we have to set something for both fields, and we were therefore setting the url_base to the full value of the input, and the path to /.

This is also related to https://github.com/airbytehq/airbyte-internal-issues/issues/11210 - I am running into this in the async Builder project as well, because we also want to have a single URL field for the different async requesters, but both url_base and path are currently required, which is making this more difficult.

Now that we are running into this in multiple places, maybe it is time that we just solve this in the CDK? To make everything work, we'd need to make the following changes:

• Make path optional in HttpRequester. If unset, just the url_base is used as the request URL.
• Add all of the interpolation_context variables that path currently has to url_base as well, so that it can access the same things in interpolation blocks

Do you think this is doable this week?

[bazarnov]

The PR is here: airbytehq/airbyte-python-cdk#370