feat: implement logic to determine super types between iceberg types #50412
+349
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
subodh1810
changed the title
frifriSF59
reviewed
Dec 24, 2024
...-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergSuperTypeFinder.kt
Outdated
Show resolved
Hide resolved
frifriSF59
reviewed
Dec 24, 2024
...-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergSuperTypeFinder.kt
Outdated
Show resolved
Hide resolved
edgao
approved these changes
Jan 2, 2025
| } | ||
|
|
||
| /** | ||
| * Combines two top-level [Type]s. If exactly one is primitive and the other is non-primitive, |
There was a problem hiding this comment.
seems like this throws is any of them are non-primitive?
frifriSF59
force-pushed
the
iceberg-schema-comparator
branch
2 times, most recently
from
b94f5f7 to
6cb11f4
Compare
frifriSF59
force-pushed
the
iceberg-schema-supertype-finder
branch
from
3b39576 to
0f58734
Compare
octavia-squidington-iii
added
the
area/documentation
# Conflicts: # airbyte-integrations/connectors/destination-s3-data-lake/src/main/kotlin/io/airbyte/integrations/destination/s3_data_lake/IcebergTypesComparator.kt # airbyte-integrations/connectors/destination-s3-data-lake/src/test/kotlin/io/airbyte/integrations/destination/s3_data_lake/IcebergTypesComparatorTest.kt
# Conflicts: # docs/integrations/destinations/s3-data-lake.md
frifriSF59
force-pushed
the
iceberg-schema-supertype-finder
branch
from
8d1f6fe to
3a7771f
Compare
|
/format-fix
|
# Conflicts: # docs/integrations/destinations/s3-data-lake.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/airbytehq/airbyte-internal-issues/issues/10918