Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize WHO Air Quality Guidelines in getAirQualityAnalytics() #3772

Open
coderabbitai bot opened this issue Oct 25, 2024 · 0 comments
Open

Externalize WHO Air Quality Guidelines in getAirQualityAnalytics() #3772

coderabbitai bot opened this issue Oct 25, 2024 · 0 comments
Assignees
@Baalmart

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

In PR #3762, within the getAirQualityAnalytics() method in src/device-registry/models/Reading.js, the WHO air quality guidelines are hardcoded. To enhance maintainability, these values should be externalized into a configuration file or constants module.

Original PR comment: Link to the comment

Requested by @Baalmart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baalmart Baalmart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Baalmart