New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor \`listAverages\` method in \`create-event.js\` #3773

Open

coderabbitai bot opened this issue Oct 25, 2024 · 0 comments

Contributor

coderabbitai bot commented Oct 25, 2024

The `listAverages` method in `src/device-registry/utils/create-event.js` can be refactored to improve error handling and code reuse.

Consider extracting common cache handling logic, defining constants for cache timeouts, and adding input validation for `site_id`.

Refer to PR #3762 and this comment.

Requested by @Baalmart.

coderabbitai bot mentioned this issue

first version of the averages API #3762

Merged

11 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment