Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency checks to make sure unit test data are identical between R and python #775

Closed
javh opened this issue Mar 4, 2024 · 6 comments
Labels
R library R reference library for AIRR standards
Milestone

Comments

@javh
Copy link
Contributor

javh commented Mar 4, 2024

The unit test data sets seems to have gotten out of sync:

  • Copy-paste to fix this.
  • Should we add consistency checks to GitHub Actions to avoid this in the future?
@schristley
Copy link
Member

@javh this is what I was referring to here. I was trying to make the test data identical and saw differences. The R version is using NA which causes python to puke. The python version was okay for R except it fails because the R test is checking specific values, that could presumably be fixed by updating the checks in the R test.

@schristley
Copy link
Member

  • Should we add consistency checks to GitHub Actions to avoid this in the future?

PR #767 has those consistency checks.

@javh
Copy link
Contributor Author

javh commented Mar 6, 2024

Ahhh... Thanks, @schristley. If we swap the NA for an empty string then that should work.

@javh javh added this to the AIRR 2.0 milestone Sep 9, 2024
@javh
Copy link
Contributor Author

javh commented Sep 9, 2024

I think this was resolved. @schristley ?

@javh javh added the R library R reference library for AIRR standards label Sep 9, 2024
@schristley
Copy link
Member

@javh still to be resolved in PR #767

@schristley
Copy link
Member

PR #767 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R library R reference library for AIRR standards
Projects
None yet
Development

No branches or pull requests

2 participants