FIX monochar emojis by displaying them smaller #4309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeSuisUnCaillou
force-pushed
the
fix/support_all_emojis
branch
from
7c4eeeb to
bc81943
Compare
|
woops, sorry, didn't mean to merge into ace master. I close that. That was an attempt to quick fix this issue for my own usage, btw : #4142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Emojis made of only one character don't have the correct cursor offset
Description of changes:
Managed to display them smaller so they correctly represent their width, monospace character wise.
It's not the best solution, I would have prefered to correctly offset the cursor, but didn't manage to do it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.