Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug with systemctl manifest if program name contains 'RUNNING' #102

Open
ov7a opened this issue Aug 22, 2016 · 0 comments
Open
Assignees

Comments

@ov7a
Copy link

ov7a commented Aug 22, 2016

Currently status check is performed by simple grep (https://github.com/ajcrowe/puppet-supervisord/blob/master/manifests/supervisorctl.pp#L25)

if $unless {
    $unless_cmd = join([$supervisorctl, 'status', $process, '|', 'grep', '-i', $unless], ' ')
  }
  else {
    $unless_cmd = undef
}

So, if program name contains any of possible statuses (ERROR, RUNNING, STOPPED, etc), systemctl program will work with errors. Such names are unlikely to be used, but may cause a lot of pain to debug this issue. At least some warning should be emitted in such case.

@ajcrowe ajcrowe added this to the 0.6.2 milestone Nov 15, 2016
@ajcrowe ajcrowe self-assigned this Nov 15, 2016
@ajcrowe ajcrowe removed this from the 0.6.2 milestone Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants