Skip to content

Latest commit

 

History

History
125 lines (86 loc) · 4.84 KB

CONTRIBUTING.md

File metadata and controls

125 lines (86 loc) · 4.84 KB
Raw

Contributing Guidelines

Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional documentation, we greatly value feedback and contributions from our community.

Please read through this document before submitting any issues or pull requests to ensure we have all the necessary information to effectively respond to your bug report or contribution.

Reporting Bugs, Features, and Enhancements

We welcome you to use the GitHub issue tracker to report bugs or suggest features and enhancements.

When filing an issue, please check existing open, or recently closed, issues to make sure someone else hasn't already reported the issue.

Please try to include as much information as you can. Details like these are incredibly useful:

  • A reproducible test case or series of steps.
  • Any modifications you've made relevant to the bug.
  • Anything unusual about your environment or deployment.

Contributing via Pull Requests

Contributions via pull requests are appreciated. Before sending us a pull request, please ensure that:

  1. You open a discussion to discuss any significant work with the maintainer(s).
  2. You open an issue and link your pull request to the issue for context.
  3. You are working against the latest source on the develop branch.
  4. You check existing open, and recently merged, pull requests to make sure someone else hasn't already addressed the problem.

To send us a pull request, please:

  1. Fork the repository.
  2. Modify the source; please focus on the specific change you are contributing.
  3. Ensure local tests pass.
  4. Updated the documentation, if required.
  5. Commit to your fork using a clear commit messages. We ask you to lease use Conventional Commits.
  6. Send us a pull request, answering any default questions in the pull request.
  7. Pay attention to any automated failures reported in the pull request, and stay involved in the conversation.

GitHub provides additional document on forking a repository and creating a pull request.

Contributor Flow

This is a rough outline of what a contributor's workflow looks like:

  • Create a topic branch from where you want to base your work.
  • Make commits of logical units.
  • Make sure your commit messages are in the proper format.
  • Push your changes to a topic branch in your fork of the repository.
  • Submit a pull request.

Example:

git remote add upstream https://github.com/ajschroeder/proxmox-packer-examples.git
git checkout -b feat/foo develop
git commit -s -a
git push origin feat/foo

Staying In Sync With Upstream

When your branch gets out of sync with the proxmox-packer-examples/develop branch, use the following to update:

git checkout feat/foo
git fetch -a
git pull --rebase upstream develop
git push --force-with-lease origin feat/foo

Updating Pull Requests

If your pull request fails to pass or needs changes based on code review, you'll most likely want to squash these changes into existing commits.

If your pull request contains a single commit or your changes are related to the most recent commit, you can simply amend the commit.

git add .
git commit --amend
git push --force-with-lease origin feat/foo

If you need to squash changes into an earlier commit, you can use:

git add .
git commit --fixup <commit>
git rebase -i --autosquash develop
git push --force-with-lease origin feat/foo

Be sure to add a comment to the pull request indicating your new changes are ready to review, as GitHub does not generate a notification when you git push.

Formatting Commit Messages

We follow the conventions on How to Write a Git Commit Message.

Be sure to include any related GitHub issue references in the commit message.

See GFM syntax for referencing issues and commits.

Reporting Bugs and Creating Issues

When opening a new issue, try to roughly follow the commit message format conventions above.

Finding Contributions to Work On

Looking at the existing issues is a great way to find something to contribute on. If you have an idea you'd like to discuss, open a discussion.

Licensing

See the LICENSE file for our project's licensing. We will ask you to confirm the licensing of your contribution.

We may ask you to sign a Contributor License Agreement (CLA) for larger changes.