Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convolution question #2

Open
egormalyutin opened this issue May 25, 2024 · 1 comment
Open

Convolution question #2

egormalyutin opened this issue May 25, 2024 · 1 comment

Comments

@egormalyutin
Copy link

Hello! Thank you for your implementation. However, I have a little question regarding the use of convolution.

        x_norm = self.layer_norm(x)
        x_conv = F.silu(self.causal_conv(x_norm.unsqueeze(1)).squeeze(1))

Does it mean that in your implementation, you are not actually doing convolution over sequence? After reading the paper, I was left with an impression that you should project 4 latest inputs and then apply swish to obtain i and f. Sorry if I'm wrong as I don't really use PyTorch.

@akaashdash
Copy link
Owner

From my understanding, we convolute over the entire sequence and not just the last 4 inputs. I'm sure there are many different ways to interpret the paper so I am open to discussing alternatives and trying them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants