Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: project config #5

Open
2 tasks done
Aleks334 opened this issue Dec 14, 2024 · 3 comments · May be fixed by #10
Open
2 tasks done

Chore: project config #5

Aleks334 opened this issue Dec 14, 2024 · 3 comments · May be fixed by #10
Assignees
Labels

Comments

@Aleks334
Copy link
Collaborator

Aleks334 commented Dec 14, 2024

  • add prettier config file
  • handle absolute paths (for imports) in vite
@Aleks334 Aleks334 self-assigned this Dec 14, 2024
@Aleks334
Copy link
Collaborator Author

Aleks334 commented Dec 14, 2024

@mit3r I think that we should move prettier config to the root dir of project, as it can be shared across frontend and backend. Unfortunately putting it in root dir doesn't work (config isn't used in client/server). I consider that we can use for example npm workspaces in root project to handle this (and common types too). Alternatively we can stick to the current version and manage prettier in frontend, backend separately. What do you think about it?

@mit3r
Copy link
Collaborator

mit3r commented Dec 14, 2024

@Aleks334 My fault. In main dir in package.json has "prettier" configuration - delete it. And add .prettierrc in main dir with

{
    "filepath": "{client,server}/**/.{js,jsx,ts,tsx,md}"
}

@Aleks334
Copy link
Collaborator Author

It works now. Thanks

@Aleks334 Aleks334 linked a pull request Dec 14, 2024 that will close this issue
@Aleks334 Aleks334 changed the title Chore: frontend config Chore: project config Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants