Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Pim version control doesn't allow version string like ^1.7 #145

Open
bpresles opened this issue Aug 3, 2018 · 0 comments
Open

Source Pim version control doesn't allow version string like ^1.7 #145

bpresles opened this issue Aug 3, 2018 · 0 comments

Comments

@bpresles
Copy link
Contributor

bpresles commented Aug 3, 2018

The source Pim version check verify that the version string on composer.json container the "1.7." string.

But when the version string is like "^1.7", which means ">= 1.7 < 2.0" and so is perfectly valid, because it confirms that the source pim is a 1.7.x version, the check doesn't work because it doesn't contain a 1.7.* version string.

This check should allow ^1.7 or ~1.7 as source pim version, that's why it should only check for "1.7"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant