-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with slashes in episode title #106
Comments
This is associated to an existing pull request, which I sadly spottet after posting. :-( |
I have fixed this. Please rebuild your container with the latest image once the current build is complete. |
Hi there and thank you very much for your reply. The problem is still there. So I checked the fileService.go in the current sourcecode. There is still Did the merge of #77 work correct? Thank you very much again and best wishes! |
I have made the change in the sanitize.Name function only. Let me check
again.
Thanks and Regards
Akhil Gupta
…On Wed, 2 Jun 2021, 11:42 pm schwammtaucher, ***@***.***> wrote:
Hi there and thank you very much for your reply.
I have rebuilt the container with the image created a few hours ago.
The problem is still there.
So I checked the fileService.go in the current sourcecode. There is still
return sanitize.Name(original)
instead of
return sanitize.BaseName(original)
Did the merge of #77 <#77> work
correct?
Thank you very much again and best wishes!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#106 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMVPVZEASEIRG3SW2LDTLTQZX7BANCNFSM45YSTPRA>
.
|
Hello there,
at first I want to say thank you for the good ideas and the very nice implementation.
I am very interested in der feature, that episode names are used as filenames. Testing with a german audio podcast I found out, that slashes in episode titles cause a minor problem in the filename.
Title in RSS: König Klops und die kleine Seiltänzerin (1/2): Ein dicker König, schwer verliebt
Resulting Filename: 2)-Ein-dicker-Koenig,-schwer-verliebt.mp3
As you can see, the slash results in splitting the string and the second Part is used as the filename. The named podcast uses a lot of slashes, because there are published different parts of stories following this scheme "1/3" (part one of three).
By the way: I realy like to see, that the german "mutated vowels" are translated in usual letters.
Here is the URL of the RSS:
https://www.ohrenbaer.de/podcast/podcast.feed.podcast.xml
Thnaky you very much for your work!
The text was updated successfully, but these errors were encountered: