Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with slashes in episode title #106

Closed
schwammtaucher opened this issue May 29, 2021 · 5 comments
Closed

Problem with slashes in episode title #106

schwammtaucher opened this issue May 29, 2021 · 5 comments

Comments

@schwammtaucher
Copy link

Hello there,
at first I want to say thank you for the good ideas and the very nice implementation.

  • Installation Type: Docker
  • Have you tried using the latest docker image / code base. yes

I am very interested in der feature, that episode names are used as filenames. Testing with a german audio podcast I found out, that slashes in episode titles cause a minor problem in the filename.

Title in RSS: König Klops und die kleine Seiltänzerin (1/2): Ein dicker König, schwer verliebt
Resulting Filename: 2)-Ein-dicker-Koenig,-schwer-verliebt.mp3

As you can see, the slash results in splitting the string and the second Part is used as the filename. The named podcast uses a lot of slashes, because there are published different parts of stories following this scheme "1/3" (part one of three).
By the way: I realy like to see, that the german "mutated vowels" are translated in usual letters.

Here is the URL of the RSS:
https://www.ohrenbaer.de/podcast/podcast.feed.podcast.xml

Thnaky you very much for your work!

@schwammtaucher
Copy link
Author

This is associated to an existing pull request, which I sadly spottet after posting. :-(
Sorry.
"Better filename sanitization #77"

@akhilrex
Copy link
Owner

akhilrex commented Jun 2, 2021

I have fixed this. Please rebuild your container with the latest image once the current build is complete.

@akhilrex akhilrex closed this as completed Jun 2, 2021
@schwammtaucher
Copy link
Author

Hi there and thank you very much for your reply.
I have rebuilt the container with the image created a few hours ago.

The problem is still there.

So I checked the fileService.go in the current sourcecode. There is still
return sanitize.Name(original)
instead of
return sanitize.BaseName(original)

Did the merge of #77 work correct?

Thank you very much again and best wishes!

@akhilrex
Copy link
Owner

akhilrex commented Jun 3, 2021 via email

@akhilrex
Copy link
Owner

akhilrex commented Jun 3, 2021

Seems to be working for me. You will have to download the older episodes again for it to come into effect.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants