-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kitty, Atuin] clone-in-kitty+eval "$(atuin init bash)" throw syntax error #554
Comments
I could reproduce the problem, but this is not an issue of # bashrc
source /path/to/bash-preexec.sh
eval "$(atuin init bash)"
if [ "${TERM}" = "xterm-kitty" ]; then
. /path/to/kitty.bash"
fi |
Is this part needed? As far as I test, kitty automatically loads this shell-integration setting even if you don't source it in # bashrc
source /path/to/bash-preexec.sh
eval "$(atuin init bash)" What is happening is that |
I'm not sure what would be the best solution to this, but I guess it would be probably having a kitty option to specify the list of environment variables that should not be copied. |
I realized that the upstream kitty actually maintains a hardcoded black list of the environment variables, so I submitted PR kovidgoyal/kitty#8275 to the upstream to add known environment variables that are used by frameworks but should not be cloned to another shell session. The PR was merged now. |
Hello! Sorry for the very late reply! I had a conference deadline I needed to meet, and life got in the way.
If you have
Makes absolute sense. It continues to amaze me how fast and to the point you solve problems like these. And how clearly you communicate your findings/the solutions. It is truly inspiring.
This is absolutely the best solution. I wish I had the time/knowledge to do it myself. Next time 😉. I tested the latest kitty version (0.39.1), and this is indeed fixed! I also want to encourage everyone to donate to this amazing project (I just donated 10$ more myself). Not only is it immensely useful, it is also lead by a developer that... Well, I do not need to describe it. Just look at how he conducts himself, and how he replies to people having problems. |
Thank you for testing the behavior in the latest version of kitty! Thank you also for those encouraging words!
Ah, actually, I didn't know that. As far as I try, if I have Then, I checked what kitty's manual says. The manual integration section explains the following setting: if test -n "$KITTY_INSTALLATION_DIR"; then
export KITTY_SHELL_INTEGRATION="enabled"
source "$KITTY_INSTALLATION_DIR/shell-integration/bash/kitty.bash"
fi where |
Hello!
I recently noticed that, in my setup, doing clone-in-kitty throws
-bash: 1737470736163691 - : syntax error: operand expected (error token is "- ")
when I haveeval "$(atuin init bash)"
on my .bashrc.My .bashrc looks like this:
Commenting out
eval "$(atuin init bash)"
fixes the issue, but disables atuin.The text was updated successfully, but these errors were encountered: