-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle images #333
Comments
I have 2 solutions for this problem:
Both approaches seem to work, and both have pros and cons. Saving the Another thing to consider is duplicates (copy/paste) of an imported image. |
Thinking in a long run, i think we should go with the second option. It is tempting to go with the first option. but take a look at the pros and cons itself |
Indeed, I went with the second option as managing images gives us more flexibility to do many more things instead of dealing with a base64 string. I'll finish this tomorrow by implementing the load of the images form the saved file, and the simple downscaling of the quality of the image if the size decreases, so Akira doesn't have to deal with super heavy images if they're smaller than the original. |
Expected Behavior
When importing a raster image such as PNG, JPG, or similar, we should create a base64 version in order to save it in memory or the file, without relying on the source image location.
We should also find a way to reduce the quality of the image based on the zoom of the canvas in order to speed up the app when dealing with multiple images.
Current Behavior
Images are imported but not saved nor converted into any other format.
Related to #326
The text was updated successfully, but these errors were encountered: