Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tracing for the generated clients #374

Closed
aperkins1310 opened this issue Aug 24, 2018 · 0 comments
Closed

Enable tracing for the generated clients #374

aperkins1310 opened this issue Aug 24, 2018 · 0 comments
Milestone

Comments

@aperkins1310
Copy link
Contributor

As the client api is currently netty based, we don't have access to the Akka HttpRequests and HttpResponses in the same way as we do for servers. This means we cannot add tracing info to the requests. Thankfully grpc-java and the netty client has OpenCensus tracing integration, it is just not enabled for the clients generated here.

Its a simple one liner to enable:
.setSampledToLocalTracing(true)

This would allow adding a module for OpenCensus Scala for akka-grpc, for tracing (and eventually Stats/ metrics as well)

Is this okay to enable by default for generated clients?

Will add a PR for this and see what the consensus is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants