Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest.json is not rewritten when updating the src/manifest.json or package.json #168

Open
EdoanR opened this issue Dec 15, 2023 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@EdoanR
Copy link

EdoanR commented Dec 15, 2023

Summary

When running npm run dev when chaning some info in the src/manifest.json or in the package.json (for example: name, version) the manifest.json in the dist folder does not update with the info I changed.

Reproduction

  1. run npm create vite-plugin-web-extension
  2. give a name for the project and choose any framework (I'm using vue-ts)
  3. go to the project folder and run npm run dev and wait for it to build.
  4. while the server still running, change the name in the package.json.
  5. manifest.json from dist folder still the same.

Environment

  System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 AMD Ryzen 5 5600G with Radeon Graphics
    Memory: 24.54 GB / 31.79 GB
  Binaries:
    Node: 18.16.0 - D:\Program Files\nodejs\node.EXE
    npm: 9.5.1 - D:\Program Files\nodejs\npm.CMD
    pnpm: 8.7.4 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Edge: Chromium (120.0.2210.61)
    Internet Explorer: 11.0.19041.3636
  npmPackages:
    vite: ^5.0.0 => 5.0.9
    vite-plugin-web-extension: ^4.0.0 => 4.0.1
@EdoanR EdoanR added the pending triage Report that needs looked at label Dec 15, 2023
@aklinker1
Copy link
Owner

aklinker1 commented Dec 27, 2023

This is a known issue. I don't think there was a GitHub issue open for it though, so thanks for opening one.

I don't plan on implementing this feature for vite-plugin-web-extension. I'm close to releasing v1.0 of wxt, the successor to this project. Once WXT v1.0 is out, I'll announce that this repo is in maintenance mode. It kinda already is, but I'm holding off on officially announcing that until then.

@aklinker1 aklinker1 added bug Something isn't working wontfix This will not be worked on and removed pending triage Report that needs looked at labels Dec 27, 2023
@EdoanR
Copy link
Author

EdoanR commented Dec 29, 2023

Thanks for the response, wxt looks pretty good, I think I will start using it. But not sure if I should close this issue thought.

@aklinker1
Copy link
Owner

Feel free to keep it open 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants