Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Healthcheck for container #189

Open
SchoolGuy opened this issue Sep 15, 2024 · 1 comment
Open

[FEAT]: Healthcheck for container #189

SchoolGuy opened this issue Sep 15, 2024 · 1 comment

Comments

@SchoolGuy
Copy link

Currently, the containerized deployment works very easily but the container engine has no knowledge about the health of the instance.

For Docker the following concept applies: https://docs.docker.com/reference/dockerfile/#healthcheck

This can be reused for k8s of course: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

For this simple purpose, I would recommend having a simple /health endpoint that returns only 200 if the exporter runs successfully.

@SchoolGuy
Copy link
Author

SchoolGuy commented Sep 15, 2024

Optionally if we want to support the concept of startup/readiness probes we could split this into three routes that return 200 on success and something else for the appropriate scenarios:

  • /health/startup - 200 as soon as the application is started
  • /health/ready - 200 as soon the config is loaded
  • /health/alive - 200 once the exporter is started

I do believe that returning a non-200 reply in case a router is not available is not appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant