-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RouterOS6 compatibility #215
Comments
I think this can be achieved by On AX3 you have You can also use both old and new capsman at the same time, if you enable |
Does dual mean qcom+wireless or just wireless? elif PackageMetricsDataSource.is_package_installed(router_entry, package_name = RouterEntryWirelessPackage.WIRELESS_PACKAGE):
self._wireless_type = RouterEntryWirelessType.DUAL and this line is only executed if there is no qcom or qcom-ac packages installed, which means its basically only checks for wireless package being installed. But later on it checks if its dual OR wireless, which would never be wireless def registration_table_paths(router_entry):
if router_entry.capsman_entry.wireless_type == RouterEntryWirelessType.DUAL:
return ['/caps-man/registration-table', f'/interface/wifi/registration-table']
elif router_entry.capsman_entry.wireless_type == RouterEntryWirelessType.WIRELESS:
return ['/caps-man/registration-table']
else:
wireless_package = WirelessMetricsDataSource.wireless_package(router_entry.capsman_entry)
return [f'/interface/{wireless_package}/registration-table'] If it is in fact supposed to be dual, I can make a pull request fixing it. |
iirc the implementation there was largely based this table. regarding 6.x support, mktxp currently provides limited compatibility which might be discontinued in the near future. Specifically for routing stats, as you can see from the exception ( or the relevant code) there is already no 6.x support. |
I knew about this documents, just wasn't sure if the project's definition of dual is corresponding to mikrotiks definition due to wireless type detecting algorithm. I've adjusted dual stack detection in PR #216 , and now it should correctly detect
This is actually a strange way to show deprecation information. If there is a network error and the program can't get routing data, this exception would be thrown. And it will continue to throw this (and other exceptions) with each scrapping, also leading to the constantly increasing log size. I'm not familiar with Python, but in other languages catching an exception is a costly operation. I've found out that mktxp works (at least after the changes in PR) perfectly fine with 6.x routers. Except the routing stats thing, but it can be disabled by overriding config parameter on device level. |
Hello,
I've tested your exporter with
951G-2HnD
that runs6.49.17
, and it cant get some info due to different commands.Is it possible to add some kind of compatibility flag that could be overloaded on router-level to use appropriate commands?
/interface/wifi/registration-table/
RB951
HAP AX3
/interface/wifi/capsman/remote-cap/print
RB951
HAP AX3
The text was updated successfully, but these errors were encountered: