Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom panel height #5

Open
Wilzi opened this issue May 18, 2015 · 2 comments
Open

Custom panel height #5

Wilzi opened this issue May 18, 2015 · 2 comments

Comments

@Wilzi
Copy link

Wilzi commented May 18, 2015

It would be great to use custom panel heights.
As I can see the scrollInterval value is set by panel group container's height and this value is multiplied by current panel index in snapToPanel function.
I think hardcoded inline CSS values in akPanel directive should set in outline CSS file.

Here is a JSbin to test the issue:
http://jsbin.com/niwikuvapi/1/edit?html,output

Thank you for this great plugin! :)
If I have some time to solve this problem I'll send a pull request

@akreitals
Copy link
Owner

Thanks for providing a JSbin right off the bat, always helpful, and PR's are always welcome :)

Allowing panels to be bigger would be a strange UX as it would snap to the next panel before you could see the bottom of the last. But I see the use case for smaller panels.

Just to scope this out a little further, a few questions. Should it be a requirement that the panel height be a submultiple of the container height? i.e. 50%, 33%, 25%, 12.5%, 10% etc? If yes would an attribute, say {{panelsPerScreen=2}} suffice? Else should any arbitrary height be allowed? Could the heights differ for each panel?

@ericodes
Copy link

I completely agree! Since sometimes a content of a 'page' is greater than the window height. Right now, with my work around, you scroll within the inner section first, and when you get to the bottom of the inner section, you continue scrolling through these angular-panels.

Would be great to be able to have min-height: 100% on each panel! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants