Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to remove spaces from IBAN before searching #32

Open
jeffallen opened this issue Mar 27, 2017 · 1 comment
Open

need to remove spaces from IBAN before searching #32

jeffallen opened this issue Mar 27, 2017 · 1 comment

Comments

@jeffallen
Copy link

In this file:
https://github.com/akretion/odoo-usability/blob/8.0/account_bank_statement_import_usability/account_bank_statement_import.py

account_number needs to be canonicalized the same way before you substitute it into the SQL query. Otherwise a search for an IBAN with spaces in it will not match, even if the IBAN in the database had spaces, because you've removed the spaces from the IBAN in the database.

I had to fix this for a client and I thought you'd like to know about it here as well.

@alexis-via
Copy link
Member

Yes, you are right. I haven't seen a bank statement file with spaces in the account number thought, that's why we haven't been bothered by that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants