-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] account_invoice_update_wizard #109
base: 11.0
Are you sure you want to change the base?
[11.0][MIG] account_invoice_update_wizard #109
Conversation
Otherwise, its value won't be sent to create method and update of lines is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review, only on migration + fix commits. LG.
Hello @sebastienbeau do you have time to give us a feedback about this? |
I don't want to anticipate @sebastienbeau response, but sadly Akretion skipped Odoo 11.0 version entirely (it's quite counter productive to try to be expert in every version) so we easily review PRs against 10.0 and 12.0, but for 11.0 it's much less likely... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional testing only.
@rvalyi I totally undersdand your point. Thanks for the quick answer
@rvalyi @sebastienbeau If you're using this module in v12.0, you might want to refactor this part: This was probably done to avoid having the wizard overwrite the changes done manually when calling its action (as |
Supersedes: #75 (as author repository doesn't exist anymore)