Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending purchase status should not result in entitlement #138

Open
kanetik opened this issue Oct 29, 2023 · 1 comment
Open

Pending purchase status should not result in entitlement #138

kanetik opened this issue Oct 29, 2023 · 1 comment

Comments

@kanetik
Copy link

kanetik commented Oct 29, 2023

Looking at the code here, it appears that if the purchase state is Pending, the customer is granted entitlement to the purchased item. However, per Google's documentation, that is the wrong way to handle Pending state. This would enable people to "purchase" the item without ever paying for it.

I think a good interim solution, so that current users of this library don't have a breaking change, would be a configuration setting that allows a dev to opt into the Google-approved model of handling Pending purchases.

@coderGtm
Copy link

I highly anticipate this vital addition. This librarys looks very good but some polishing is required. I am ready to contribute code, but I'd need some background from the maintainers about how and where to go for preventing entitlement in case of pending purchases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants