From 0ac6d166fd210c66037ae3ce30290c001bd3d9e8 Mon Sep 17 00:00:00 2001 From: Kent Rancourt Date: Fri, 24 Jan 2025 13:44:04 -0500 Subject: [PATCH] fix: tolerate entra id pkce spec deviation Signed-off-by: Kent Rancourt --- ui/src/features/auth/oidc-login.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/src/features/auth/oidc-login.tsx b/ui/src/features/auth/oidc-login.tsx index f924e52bf..2902f9eb1 100644 --- a/ui/src/features/auth/oidc-login.tsx +++ b/ui/src/features/auth/oidc-login.tsx @@ -65,7 +65,8 @@ export const OIDCLogin = ({ oidcConfig }: Props) => { }) .then((response) => processDiscoveryResponse(issuerUrl, response)) .then((response) => { - if (response.code_challenge_methods_supported?.includes('S256') !== true) { + if (response.code_challenge_methods_supported?.includes('S256') !== true && + !issuerUrl.toString().startsWith('https://login.microsoftonline.com')) { throw new Error('OIDC config fetch error'); }