Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the PR when the Promotion is aborted #3435

Open
shabbir-saifee-cmm opened this issue Feb 4, 2025 · 3 comments
Open

Close the PR when the Promotion is aborted #3435

shabbir-saifee-cmm opened this issue Feb 4, 2025 · 3 comments

Comments

@shabbir-saifee-cmm
Copy link

shabbir-saifee-cmm commented Feb 4, 2025

Checklist

  • [ X ] I've searched the issue queue to verify this is not a duplicate feature request.
  • [ X ] I've pasted the output of kargo version, if applicable.
  • [ X ] I've pasted logs, if applicable.

Proposed Feature

Close the PR when the Promotion is aborted

Image
Image

Motivation

Suggested Implementation

@krancour
Copy link
Member

Noting here that this ought not be addressed in a vacuum.

#2972 aims to make behavior configurable when a Promotion fails (or is aborted, I suppose).

It would be best to solve that first.

fwiw, it may better to work in the other direction. Instead of aborting the Promo and counting on that to close the PR, you could close the PR and count on that to fail the Promo. That already works.

@jessesuen
Copy link
Member

Alternative proposal: #3639

@krancour
Copy link
Member

#3639 + a close-pr step would work nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants