Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE flow leaves out state parameter required by Okta #3575

Open
remi-gelinas opened this issue Feb 26, 2025 · 2 comments
Open

PKCE flow leaves out state parameter required by Okta #3575

remi-gelinas opened this issue Feb 26, 2025 · 2 comments

Comments

@remi-gelinas
Copy link

remi-gelinas commented Feb 26, 2025

Checklist

  • [x ] I've searched the issue queue to verify this is not a duplicate bug report.
  • [x ] I've included steps to reproduce the bug.
  • [x ] I've pasted the output of kargo version.
  • [x ] I've pasted logs, if applicable.

Description

This is the same issue raised for ArgoCD in argoproj/argo-cd#17217. Per Okta docs, they require a state parameter passed during authorization despite it not technically being required by spec when PKCE is in use.

Steps to Reproduce

Create an Okta OIDC Single Page Application, and enable PKCE. Attempting to authorize with Kargo will return a 400 because the authorization request is missing a state parameter.

Version

{
  "Version": "v1.2.3",
  "BuildDate": "2025-02-19T13:13:42Z",
  "GitCommit": "66b633b77186bd25c49c0618dac3a1379bd1aa3a",
  "GitTreeDirty": false,
  "GoVersion": "go1.23.6",
  "Compiler": "gc",
  "Platform": "linux/amd64"
}

Logs

N/A

@krancour
Copy link
Member

#2916 partially addresses this, but hasn't been sufficiently validated.

@remi-gelinas I know you already found that issue and commented on it. I'm just adding this comment to establish the relationship between this issue and that PR. Neither previously made any mention of the other.

@remi-gelinas
Copy link
Author

Yes, thank you - I did a cursory search for previous issues, but not existing PRs.

Happy to see a fix already proposed, even if it still has to be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants